Refactor: Move personal user settings page to Vue #4388
Conversation
codewithvk
force-pushed
the
private/codewithvk/user_settings_vue_migration
branch
from
1ff6a91 to
ca586cb
Compare
codewithvk
force-pushed
the
private/codewithvk/user_settings_vue_migration
branch
from
ca586cb to
c202b79
Compare
codewithvk
force-pushed
the
private/codewithvk/user_settings_vue_migration
branch
from
c202b79 to
5fcfc07
Compare
elzody
left a comment
elzody
left a comment
There was a problem hiding this comment.
Sorry if I was being a bit picky here, but I made a few comments and suggestions. If you need any help don't hesitate to ask
codewithvk
force-pushed
the
private/codewithvk/user_settings_vue_migration
branch
2 times, most recently
from
1b32389 to
0084cd6
Compare
elzody
left a comment
elzody
left a comment
There was a problem hiding this comment.
Looks good. The only thing left before merging is to fix the failing test, which you can likely do by just running composer run cs:fix and committing the changes.
codewithvk
force-pushed
the
private/codewithvk/user_settings_vue_migration
branch
from
0084cd6 to
b561d82
Compare
Signed-off-by: codewithvk <[email protected]>
codewithvk
force-pushed
the
private/codewithvk/user_settings_vue_migration
branch
from
b561d82 to
3572c8b
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
Checklist